Skip to content

covers a few more stickykey cases #8712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hry-gh
Copy link
Member

@hry-gh hry-gh commented Mar 9, 2025

stickykeys could also occur by the browser sending more key events /after/ it stopped rendering itself

🆑
fix: fixes sticky keys (even more)
/:cl:

@github-project-automation github-project-automation bot moved this to Awaiting Review in Review Backlog Mar 9, 2025
@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Fix Fix one bug, make ten more labels Mar 9, 2025
@Git-Nivrak
Copy link
Contributor

best pr of 2025

@Red-byte3D

This comment was marked as off-topic.

@github-project-automation github-project-automation bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog Mar 11, 2025
@Drulikar Drulikar added this pull request to the merge queue Mar 11, 2025
Merged via the queue into cmss13-devs:master with commit dd81000 Mar 11, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Partially Approved / Mergeable to Merged in Review Backlog Mar 11, 2025
cmss13-ci bot added a commit that referenced this pull request Mar 11, 2025
ihatethisengine pushed a commit to ihatethisengine/cmss13 that referenced this pull request Mar 14, 2025
stickykeys could also occur by the browser sending more key events
/after/ it stopped rendering itself

:cl:
fix: fixes sticky keys (even more)
/:cl:

Co-authored-by: harryob <[email protected]>
ihatethisengine pushed a commit to ihatethisengine/cmss13 that referenced this pull request Mar 14, 2025
Absolucy added a commit to Absolucy/Monkestation that referenced this pull request Mar 26, 2025
Absolucy added a commit to Monkestation/Monkestation2.0 that referenced this pull request Mar 27, 2025
## About The Pull Request

im just throwing a bunch of bugfixes, cleanups, maybe some minor stuff
into this PR, bc I'm too lazy to split things up.
dw i'll actually do the changelog

<img alt="cat-like typing detected"
src="https://github.com/user-attachments/assets/cfb61ff8-c0b9-4889-9563-9bb2fe6c35aa"
width="50%">

**Ports**:
- BeeStation/BeeStation-Hornet#12240 (the color
picker fix specifically)
- tgstation/tgstation#74884
- tgstation/tgstation#78984
- tgstation/tgstation#80521
- tgstation/tgstation#81433
- tgstation/tgstation#83329
- tgstation/tgstation#83427
- tgstation/tgstation#85302
- tgstation/tgstation#86339
- tgstation/tgstation#86959
- tgstation/tgstation#88791
- tgstation/tgstation#89110
- tgstation/tgstation#89164
- tgstation/tgstation#89374
- tgstation/tgstation#89802
- tgstation/tgstation#89885
- tgstation/tgstation#90005
- tgstation/tgstation#90045
- tgstation/tgstation#90140
- tgstation/tgstation#90154
- tgstation/tgstation#90207
- tgstation/tgstation#90215
- tgstation/tgstation#90227 (which is actually a
partial port of _this PR_ but whatever)
- tgstation/tgstation#90256
- cmss13-devs/cmss13#8674
- cmss13-devs/cmss13#8712
- cmss13-devs/cmss13#8875

Fixes #5837
Fixes #5872
Fixes #6010
Fixes #6049
Fixes #6061
(probably)
Fixes #6067

some bugfixes, some ports

## Changelog
:cl:
fix: Toxins no longer damage your liver if you are immune to toxins
anyways.
fix: Fixed an edge-case where, if two heretics of different paths
applied a mark to the same person, the effects from the first mark (i.e
moon path's pacifism) would likely be permanent.
code: Slightly improved the code for the Cortex Imprint bioware.
fix: Fixed an centcom ghost player escape exploit.
fix: You will now be ejected from any jaunt (i.e bloodcrawl or shadow
walk) if you lose consciousness somehow during the jaunt.
fix: The _ispath SDQL2/Lua wrapper can now be used to actually check if
something is a path.
code: Added the _is_type_in_typecache wrapper, for SDQL2 / Lua scripts.
fix: Probably fixed techfab/lathe/mechfab UIs not updating sometimes.
fix: The animation from a xeno chestbursting out of someone is now
properly removed after they burst out.
fix: You now must observe or join the game in order to buy or open a
lootbox, to prevent any potential issues or confusion where you pay for
a lootbox but don't get it.
qol: The Good Assistants Point redeemer thingy can no longer be used to
spam messages or loud sounds.
fix: (itsmeow) The tgui color picker is colorful again on BYOND 516.
qol: (SmArtKar) If you have auto fit viewport enabled, it will trigger
upon entering or exiting fullscreen.
add: (jlsnow301) TGUI icons are updated to latest FontAwesome version,
v6.7.2.
fix: (TiviPlus) fixed a case that could make untoggling fullscreen make
your window small.
code: (TiviPlus) Cleaned up some fullscreen and status bar toggle code
to function better.
fix: (Holoo-1) Fixed white space when observing in auto observe mode
refactor: (Kylerace) Tech disk uploading isnt super slow anymore (much
harder to crash spacetime with it)
code: (SmArtKar) Removed the 516 beta warning entirely.
fix: (hry-gh) tgui windows closing should no longer cause sticky keys,
especially on BYOND 516.
fix: (hry-gh) The audio player shouldn't blow up in weird circumstances
anymore.
/:cl:

---------

Co-authored-by: Ghom <[email protected]>
Co-authored-by: Holoo <[email protected]>
Co-authored-by: LemonInTheDark <[email protected]>
Co-authored-by: Penelope Haze <[email protected]>
Co-authored-by: Kyle Spier-Swenson <[email protected]>
Co-authored-by: Mothblocks <[email protected]>
Co-authored-by: san7890 <[email protected]>
Co-authored-by: SmArtKar <[email protected]>
Co-authored-by: Zephyr <[email protected]>
Co-authored-by: TiviPlus <[email protected]>
Co-authored-by: TiviPlus <[email protected]>
Co-authored-by: MichiRecRoom <[email protected]>
Co-authored-by: Kylerace <[email protected]>
Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: hack-wrench <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more UI deletes nanoui/html
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants